Remove index_analyzer setting to simplify analyzer logic
#9451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjernst
added
:Search/Mapping
| builder.indexAnalyzer(getNamedAnalyzer(parserContext, fieldNode.toString())); | ||
| if (Fields.ANALYZER.equals(fieldName) || | ||
| // for backcompat, reading old indexes, remove for v3.0 | ||
| fieldName.equals("index_analyzer") && parserContext.indexVersionCreated().before(Version.V_2_0_0)) { |
There was a problem hiding this comment.
I was a bit confused that this is part of the if statement yet has the same indentation level that the block of code below. Maybe add 2 or 4 spaces of indentation here?
|
LGTM Just left some notes about readability, feel free to push without further review. |
The `analyzer` setting is now the base setting, and `search_analyzer` is simply an override of the search time analyzer. When setting `search_analyzer`, `analyzer` must be set. closes elastic#9371
clintongormley
changed the title
index_analyzer setting to simplify analyzer logicindex_analyzer setting to simplify analyzer logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
analyzersetting is now the base setting, andsearch_analyzeris simply an override of the search time analyzer. When setting
search_analyzer,analyzermust be set.closes #9371