Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable auto gen id optimization #9468

Closed
wants to merge 3 commits into from
Closed

Commits on Jan 28, 2015

  1. core: fix duplicate docs with autogenerated ids

    When an indexing request is retried (due to connect lost, node closed etc),
    then a flag 'canHaveDuplicates' is set to true for the indexing request
    that is send a second time. This was to make sure that even
    when an indexing request for a document with autogenerated id comes in
    we do not have to update unless this flag is set and instead only append.
    
    However, it might happen that for a retry or for the replication the
    indexing request that has the canHaveDuplicates set to true (the retried request) arrives
    at the destination before the original request that does have it set false.
    In this case both request add a document and we have a duplicated a document.
    This commit adds a workaround: remove the optimization for auto
    generated ids and always update the document.
    The asumtion is that this will not slow down indexing more than 10 percent,
    see: http://benchmarks.elasticsearch.org/
    
    closes elastic#8788
    brwe committed Jan 28, 2015
    Configuration menu
    Copy the full SHA
    bf7752e View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2015

  1. Configuration menu
    Copy the full SHA
    5eb7247 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2871413 View commit details
    Browse the repository at this point in the history