[Storybook] Add stories for more components (letter T) - Part 3 #7745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgadewoll
added
documentation
mgadewoll
force-pushed
the
storybook/7484-stories-t-part-3
branch
from
cf80579
to
9941937
Compare
tkajtoch
reviewed
May 16, 2024
| content: 'tooltip content', | ||
| iconProps: { | ||
| // using autoFocus here as small trick to ensure showing the tooltip on load (e.g. for VRT) | ||
| // TODO: exchange for loki play() interactions once #7735 is merged |
There was a problem hiding this comment.
I think we can replace it with an interaction now :)
There was a problem hiding this comment.
Yes and No 😅
The mentioned PR is merged but we realized there are issues running Loki interactions on the LOKI_SELECTORS.portal (e.g. EuiComboBox VRT also is broken) - I think you mentioned that you wanted to fix this in this PR?
There was a problem hiding this comment.
I updated the comment to the Loki fix PR instead and added the interactions already but commented out. (commit)
|
Code looks great and the changes work correctly when tested in PR environment! Could you please resolve the interaction VRT TODOs in this PR? |
mgadewoll
force-pushed
the
storybook/7484-stories-t-part-3
branch
from
9941937
to
d862db1
Compare
|
Preview staging links for this PR:
|
💚 Build Succeeded
History
|
tkajtoch
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #7484
This PR adds more stories for components with the letter T:
Additionally adds base VRT reference images based on the added stories.
QA
Confirm that the prop controls for all the below stories provide relevant controls and that those controls work as expected:
https://eui.elastic.co/pr_7745/storybook/index.html?path=/story/display-euitoken--playground
https://eui.elastic.co/pr_7745/storybook/index.html?path=/story/display-euitooltip--playground
https://eui.elastic.co/pr_7745/storybook/index.html?path=/story/display-euiicontip--playground
https://eui.elastic.co/pr_7745/storybook/index.html?path=/story/display-euitour-euitour--playground
https://eui.elastic.co/pr_7745/storybook/index.html?path=/story/display-euitour-euitourstep--playground
https://eui.elastic.co/pr_7745/storybook/index.html?path=/story/display-euitour-euitourstepindicator--playground