Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crowdstrike: refactor alert and host collectors and improve error handling #9716

Merged
merged 3 commits into from May 1, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Apr 26, 2024

Proposed commit message

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request Integration:Crowdstrike Team:Security-Service Integrations Security Service Integrations Team labels Apr 26, 2024
@efd6 efd6 self-assigned this Apr 26, 2024
@efd6 efd6 force-pushed the crowdstrike_errors_refactor branch from cdcbfe2 to cbd7f83 Compare April 26, 2024 08:38
@efd6 efd6 changed the title crowdstrike: refactor alert and host collector and improve error handling crowdstrike: refactor alert and host collectors and improve error handling Apr 26, 2024
@efd6
Copy link
Contributor Author

efd6 commented Apr 26, 2024

/test

@elasticmachine
Copy link

elasticmachine commented Apr 26, 2024

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@efd6 efd6 marked this pull request as ready for review April 26, 2024 09:48
@efd6 efd6 requested a review from a team as a code owner April 26, 2024 09:48
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@efd6 efd6 force-pushed the crowdstrike_errors_refactor branch from cbd7f83 to 98f5448 Compare May 1, 2024 21:56
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @efd6

@efd6 efd6 merged commit 014d709 into elastic:main May 1, 2024
5 checks passed
@elasticmachine
Copy link

Package crowdstrike - 1.33.0 containing this change is available at https://epr.elastic.co/search?package=crowdstrike

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:Crowdstrike Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants