Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[integrations][Custom GCS] - Converted Custom GCS integration to Input Package type #9725

Merged
merged 37 commits into from May 6, 2024
Merged

[integrations][Custom GCS] - Converted Custom GCS integration to Input Package type #9725

merged 37 commits into from May 6, 2024

Conversation

ShourieG
Copy link
Contributor

@ShourieG ShourieG commented Apr 26, 2024 •
edited

Type of change

  • Enhancement

Proposed commit message

Converted Custom GCS Integration to Input Package according to the specs located here - https://github.com/elastic/package-spec/tree/29cc306237b541e7c32841548c09e25dcfd19333/spec/input.

Note

Ignore older commits created due to fork being out of sync.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • Verified upgrade process and confirmed state is kept intact post upgrade.

How to test this PR locally

Related issues

Screenshots

ShourieG and others added 30 commits November 15, 2023 16:19
@ShourieG
refactored the integration, added new parameters and improved documen…
d092526 
…tation for making integration GA
@ShourieG
Merge remote-tracking branch 'upstream/main'
6aed381
@ShourieG
merged with main and resolved merge conflicts
043affd
@ShourieG
Merge remote-tracking branch 'upstream/main'
74cd1da
@ShourieG
Merge remote-tracking branch 'upstream/main'
e2981a8
@ShourieG
Merge remote-tracking branch 'upstream/main'
be9a913
@ShourieG
Merge remote-tracking branch 'upstream/main'
301df37
@ShourieG
Merge remote-tracking branch 'upstream/main'
b19996c
@ShourieG
Merge remote-tracking branch 'upstream/main'
1fb0cbe
@ShourieG
Merge remote-tracking branch 'upstream/main'
2832f71
@ShourieG
Merge remote-tracking branch 'upstream/main'
aa36ffe
@ShourieG
Merge remote-tracking branch 'upstream/main'
6de9853
@ShourieG
Merge remote-tracking branch 'upstream/main'
2b7fdb2
@ShourieG
Merge remote-tracking branch 'upstream/main'
3208dff
@ShourieG
Merge remote-tracking branch 'upstream/main'
23c49a3
@ShourieG
Merge remote-tracking branch 'upstream/main'
b4f19e6
@ShourieG
Merge remote-tracking branch 'upstream/main'
a601c9f
@ShourieG
Merge remote-tracking branch 'upstream/main'
4bab737
@ShourieG
Merge remote-tracking branch 'upstream/main'
3305f7d
@ShourieG
Merge remote-tracking branch 'upstream/main'
fea5b77
@ShourieG
Merge remote-tracking branch 'upstream/main'
82566d3
@ShourieG
Merge remote-tracking branch 'upstream/main'
16699cf
@ShourieG
Merge remote-tracking branch 'upstream/main'
5f9465e
@ShourieG
[Netskope] - Added support for custom tcp options & upgraded stack re…
d7af4ef 
…quirements to ^8.7.0 (elastic#9605)

* refactored the integration, added new parameters and improved documentation for making integration GA

* Added support for custom tcp options & upgraded kibana stack requiurements to ^8.7.0 for input metrics support

* updated changelog

* addressed PR suggestions
@janvi-elastic @ShourieG
[citrix_adc] Update description to include log processing (elastic#9562)
ab0e9d6 
* Update description for logs
@ShourieG
rebased with upstream/main
9641969
@ShourieG
Merge branch 'main' into HEAD
2413680
@ShourieG
Merge remote-tracking branch 'upstream/main'
415f35f
@ShourieG
initial refacor to input package completed with working tests
b50ab23
@ShourieG
updated readme
711a120
@ShourieG ShourieG requested a review from a team as a code owner April 26, 2024 14:29
@ShourieG ShourieG requested a review from kcreddy April 26, 2024 14:29
@ShourieG ShourieG self-assigned this Apr 26, 2024
@ShourieG ShourieG added 8.14 candidate integration Label used for meta issues tracking each integration enhancement New feature or request Team:Security-Service Integrations Security Service Integrations Team labels Apr 26, 2024
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

efd6
efd6 reviewed Apr 28, 2024
View reviewed changes
packages/google_cloud_storage/docs/README.md Outdated Show resolved Hide resolved
packages/google_cloud_storage/fields/agent.yml Outdated Show resolved Hide resolved
packages/google_cloud_storage/manifest.yml Outdated Show resolved Hide resolved
packages/google_cloud_storage/manifest.yml Outdated Show resolved Hide resolved
@ShourieG ShourieG removed the request for review from kcreddy April 29, 2024 06:35
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @ShourieG

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@ShourieG
Copy link
Contributor Author

ShourieG commented May 2, 2024

@efd6, Addressed all the pr suggestions

@ShourieG ShourieG merged commit b4cb1df into elastic:main May 6, 2024
5 checks passed
@ShourieG ShourieG deleted the ip_migration/gcs branch May 6, 2024 07:06
@elasticmachine
Copy link

Package google_cloud_storage - 2.0.0 containing this change is available at https://epr.elastic.co/search?package=google_cloud_storage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

Assignees

@ShourieG ShourieG

Labels
8.14 candidate enhancement New feature or request integration Label used for meta issues tracking each integration Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert Custom GCS package to input type
4 participants
@ShourieG @elasticmachine @efd6 @janvi-elastic