Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Obs Alerts > Alert Detail][KEYBOARD]: Table header has tooltips that must be keyboard focusable #183523

Merged
merged 4 commits into from
May 16, 2024

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented May 15, 2024

Closes: https://github.com/elastic/observability-dev/issues/3379

Description

The Obs Alert Detail view has a table with several tooltips that are not keyboard focusable. Screenshot attached below.

Steps to recreate

  1. Open the Obs Alerts table
  2. Click the "Manage Rules" link
  3. Create a new rule and verify it appears in the Rules table if you have none that are generating alerts
  4. When the rule appears in the Rules table, click the [ ... ] menu and then click "Run rule"
  5. After the rule runs, go back to the Alerts view and click on the [ ... ] menu in the data grid, then click on "View alert details"
  6. Tab through the page until you get to the table
  7. Verify the tooltips can be accessed with mouse hover, but not keyboard focus

What was changed?:

  1. EuiTooltip was replaced to EuiIconTip

Screen

Screen.Recording.2024-05-15.at.17.09.29.mov

@alexwizp alexwizp changed the title fix: [Obs Alerts > Alert Detail][KEYBOARD]: Table header has tooltips… fix: [Obs Alerts > Alert Detail][KEYBOARD]: Table header has tooltips that must be keyboard focusable May 15, 2024
@alexwizp
Copy link
Contributor Author

/ci

@alexwizp alexwizp added release_note:skip Skip the PR/issue when compiling release notes v8.15.0 Team:Observability Team label for Observability Team (for things that are handled across all of observability) Project:Accessibility labels May 15, 2024
@alexwizp alexwizp marked this pull request as ready for review May 15, 2024 19:32
@alexwizp alexwizp requested a review from a team as a code owner May 15, 2024 19:32
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@elasticmachine
Copy link
Contributor

Pinging @elastic/unified-observability (Team:Observability)

Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up! There is a variant of this table that follows the same pattern, would be great if you can update that one too. It's log_rate_analysis_results_table_groups.tsx in the same folder. That table will render when "Smart grouping" is enabled:

image

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 521.4KB 521.2KB -181.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest changes LGTM! 🥳

@alexwizp alexwizp merged commit 38e7ab2 into elastic:main May 16, 2024
18 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes Team:Observability Team label for Observability Team (for things that are handled across all of observability) v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants