Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After installing as a plugin, support-diagnostics.sh is not executable #2

Closed
seang-es opened this issue Sep 9, 2014 · 6 comments
Closed

Comments

@seang-es
Copy link

seang-es commented Sep 9, 2014

File permissions are 644 on support-diagnostics.sh. Those should be 755 so it can be immediately executed.

@clintongormley
Copy link

This should already be handled by
elastic/elasticsearch#7177

@seang-es
Copy link
Author

seang-es commented Sep 9, 2014

Maybe it's a regression...I just installed on my mac and it was not executable.

@pickypg
Copy link
Member

pickypg commented Sep 9, 2014

If the commiter is using Windows, I have found it rarely remembers the
permissions correctly.

On Tue, Sep 9, 2014 at 4:23 PM, Sean Gallagher notifications@github.com
wrote:

Maybe it's a regression...I just installed on my mac and it was not
executable.


Reply to this email directly or view it on GitHub
#2 (comment)
.

@seang-es
Copy link
Author

seang-es commented Sep 9, 2014

This whole repo was also blown away and recreated when we released the plugin, so file permissions may not have survived that.

@spinscale
Copy link

@seang-es elastic/elasticsearch#7177 is for 1.4 and above, so far we never set the executable bit and we also do not recover the file permissions from the archive

@jjfalling
Copy link
Contributor

Looks like this is now fixed. Although it is worth mentioning that the permissions default to 744, but I think this is the intended behavior in es.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants