Refactoring to make MessageChannelHandler extensible #6915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| requestDecoder.setMaxCumulationBufferCapacity(Integer.MAX_VALUE); | ||
| } else { | ||
| requestDecoder.setMaxCumulationBufferCapacity((int) transport.maxCumulationBufferCapacity.bytes()); | ||
| public ChannelPipelineFactory configureServerChannelPipelineFactory() { |
There was a problem hiding this comment.
can the implementation still be a static factory class that is returned?
|
LGTM |
|
created static classes and added tests, should be ready now |
|
|
||
| private final NettyHttpServerTransport transport; | ||
| private static class HttpChannelPipelineFactory implements ChannelPipelineFactory { |
|
few comments, other than that LGTM |
|
LGTM |
Small refactorings to make the MessageChannelHandler more extensible. Also allowed access to the different netty pipelines This is the fix after the first version had problems with the HTTP transport due to wrong reusing channel handlers, which is the reason why tests failed. Relates elastic#6889 Closes elastic#6915
spinscale
added a commit
that referenced
this pull request
Jul 18, 2014
Small refactorings to make the MessageChannelHandler more extensible. Also allowed access to the different netty pipelines This is the fix after the first version had problems with the HTTP transport due to wrong reusing channel handlers, which is the reason why tests failed. Relates #6889 Closes #6915
|
Awesome, this should make it possible for someone to write the SSL transport support as a plugin. I had investigated going down this route a while back but got stuck because of the shading of the Netty jar. It tossed a bunch of the Netty code that was not used in ES but needed if I wanted to add the SSL support. |
clintongormley
changed the title
clintongormley
added
the
:Distributed/Network
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small refactorings to make the MessageChannelHandler more extensible.
Also allowed access to the different netty pipelines
This is the fix after the first version had problems with the HTTP
transport due to wrong reusing channel handlers, which is the reason
why tests failed. This version now uses its own ChannelPipelineFactory
again.
Relates #6889 (which had been reverted in the first place)