Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring to make Netty MessageChannelHandler extensible #6889

Merged
merged 1 commit into from Jul 17, 2014

Conversation

Projects
None yet
4 participants
@spinscale
Copy link
Member

commented Jul 16, 2014

Small refactorings to make the MessageChannelHandler more extensible.
Also allowed access to the different netty pipelines

@uboness

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2014

LGTM

@spinscale spinscale added the review label Jul 16, 2014

Netty: Refactoring to make MessageChannelHandler extensible
Small refactorings to make the MessageChannelHandler more extensible.
Also allowed access to the different netty pipelines

Closes #6889

@spinscale spinscale merged commit db7f0d3 into elastic:master Jul 17, 2014

spinscale added a commit that referenced this pull request Jul 17, 2014

Netty: Refactoring to make MessageChannelHandler extensible
Small refactorings to make the MessageChannelHandler more extensible.
Also allowed access to the different netty pipelines

Closes #6889

@jpountz jpountz removed the review label Jul 17, 2014

spinscale added a commit to spinscale/elasticsearch that referenced this pull request Jul 18, 2014

Netty: Refactoring to make MessageChannelHandler extensible
Small refactorings to make the MessageChannelHandler more extensible.
Also allowed access to the different netty pipelines

This is the fix after the first version had problems with the HTTP
transport due to wrong reusing channel handlers, which is the reason
why tests failed.

Relates elastic#6889
Closes elastic#6915

spinscale added a commit that referenced this pull request Jul 18, 2014

Netty: Refactoring to make MessageChannelHandler extensible
Small refactorings to make the MessageChannelHandler more extensible.
Also allowed access to the different netty pipelines

This is the fix after the first version had problems with the HTTP
transport due to wrong reusing channel handlers, which is the reason
why tests failed.

Relates #6889
Closes #6915

@clintongormley clintongormley changed the title Netty: Refactoring to make MessageChannelHandler extensible Internal: Refactoring to make Netty MessageChannelHandler extensible Sep 8, 2014

@clintongormley clintongormley changed the title Internal: Refactoring to make Netty MessageChannelHandler extensible Refactoring to make Netty MessageChannelHandler extensible Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.