Better heuristic for setting default shard_size in terms aggregation
#6960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -51,6 +52,11 @@ public AggregatorFactory parse(String aggregationName, XContentParser parser, Se | |||
| aggParser.parse(aggregationName, parser, context, vsParser, incExcParser); | |||
|
|
|||
| TermsAggregator.BucketCountThresholds bucketCountThresholds = aggParser.getBucketCountThresholds(); | |||
| if (bucketCountThresholds.getShardSize() == aggParser.getDefaultBucketCountThresholds().getShardSize()) { | |||
There was a problem hiding this comment.
I think we should not do it when the order is based on the term?
|
Left one comment but it looks good! |
|
LGTM |
|
Merged into master and 1.x |
clintongormley
changed the title
|
Hey @colings86 can we update our docs according to this change? |
|
Docs updated in #9873 |
clintongormley
changed the title
shard_size in terms aggregation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default shard size in the terms aggregation now uses BucketUtils.suggestShardSideQueueSize() to set the shard size if the user does not specify it as a parameter.
Closes #6857