Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error for invalid multipolygon #7190

Merged
merged 1 commit into from Aug 12, 2014
Merged

Better error for invalid multipolygon #7190

merged 1 commit into from Aug 12, 2014

Conversation

colings86
Copy link
Contributor

Closes #7126

@clintongormley
Copy link

I actually like the message in the assertion better :) How about:

Invalid polygon: Two edges cross the date line at the same position

@colings86
Copy link
Contributor Author

@clintongormley the problem is that the message in the assertion is not the only reason for the exception being thrown (i.e. it was always the wrong message). For example, in this case there are not two edges crossing the date line at the same position, the problem is that the polygon representing the hole is not inside the main polygon.

@clintongormley
Copy link

ahhh right, ok, how about "Invaild shape: Hole is not within polygon"

@jpountz
Copy link
Contributor

jpountz commented Aug 11, 2014

LGTM

@jpountz jpountz removed the review label Aug 11, 2014
@colings86 colings86 merged commit 128b83e into elastic:master Aug 12, 2014
@colings86 colings86 deleted the fix/7126 branch August 13, 2014 08:10
@colings86 colings86 self-assigned this Aug 21, 2014
@clintongormley clintongormley added the :Analytics/Geo Indexing, search aggregations of geo points and shapes label Jun 7, 2015
@clintongormley clintongormley changed the title Geo: Better error for invalid multipolygon Better error for invalid multipolygon Jun 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >bug v1.4.0.Beta1 v2.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geo: geo_shape MultiPolygon parsing problem
3 participants