Test: Improve test coverage #7428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -224,6 +224,7 @@ protected XContentBuilder toInnerXContent(XContentBuilder builder, Params params | |||
| ArrayList<String> result = Lists.newArrayList(); | |||
| while (token != Token.END_ARRAY) { | |||
| result.add(GeoUtils.parseGeoPoint(parser).geohash()); | |||
| token = parser.nextToken(); //infinite loop without this line | |||
There was a problem hiding this comment.
I think we have to break this fix out and apply it to 1.3 as well? I guess cherry-picking 4206b236112983305dc72fa4119b52f114d235c2 should do it and we can open a quick issue for it?
|
I left one comment otherwise this LGTM |
s1monw
added a commit
that referenced
this pull request
Aug 25, 2014
dadoonet
added a commit
to elastic/elasticsearch-cloud-azure
that referenced
this pull request
Sep 5, 2014
`Strings.startsWithIgnoreCase()` has been removed in elasticsearch 1.4 ans master. See elastic/elasticsearch#7428 Closes #35.
dadoonet
added a commit
to elastic/elasticsearch-cloud-azure
that referenced
this pull request
Sep 5, 2014
`Strings.startsWithIgnoreCase()` has been removed in elasticsearch 1.4 ans master. See elastic/elasticsearch#7428 Closes #35.
s1monw
added a commit
that referenced
this pull request
Sep 8, 2014
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves code coverage by removing dead code and adding tests to features/utility classes that were not sufficiently tested.