Support for artificial documents #7530
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the ability to the Term Vector API to generate term vectors for artifical documents, that is for documents not present in the index. Following a similar syntax to the Percolator API, a new 'doc' parameter is used, instead of '_id', that specifies the document of interest. The parameters '_index' and '_type' determine the mapping and therefore analyzers to apply to each value field.
| numbers have no meaning in this context. | ||
| numbers have no meaning in this context. By default, when requesting | ||
| term vectors of artificial documents, a shard to get the statistics from | ||
| is randomly selected. Use `routing` only to hit a particular shard. |
There was a problem hiding this comment.
Doesn't the term vectors API currently return statistics that are aggregated across all shards? Documentation suggests so?
There was a problem hiding this comment.
Nope it does not.
"The term and field statistics are not accurate. Deleted documents are not taken into account. The information is only retrieved for the shard the requested document resides in."
| private String routing; | ||
|
|
||
| protected String preference; | ||
|
|
||
| private static AtomicInteger randomInt = new AtomicInteger(0); |
|
@alexksikes I left some comments |
|
@jpountz Thanks for comments. We should decide on allowing dynamic mappings or not, and if not what would be the easiest way to implement it? I'd be in favor of disabling dynamic mapping and only returning the TVs from the fields found in the original mapping. That because there is just too much room for mistakes and unintended behaviors. Maybe @clintongormley has some ideas? |
| that is for documents not present in the index. The syntax is similar to the | ||
| <<search-percolate,percolator>> API. For example, the following request would | ||
| return the same results as in example 1. The mapping used is determined by the | ||
| `index` and `type`. |
There was a problem hiding this comment.
Can you leave a note about the fact that it can introduce new mappings?
|
I left some comments but I think it is close |
|
LGTM |
alexksikes
added a commit
that referenced
this pull request
Sep 5, 2014
This adds the ability to the Term Vector API to generate term vectors for artifical documents, that is for documents not present in the index. Following a similar syntax to the Percolator API, a new 'doc' parameter is used, instead of '_id', that specifies the document of interest. The parameters '_index' and '_type' determine the mapping and therefore analyzers to apply to each value field. Closes #7530
alexksikes
added a commit
that referenced
this pull request
Sep 8, 2014
This adds the ability to the Term Vector API to generate term vectors for artifical documents, that is for documents not present in the index. Following a similar syntax to the Percolator API, a new 'doc' parameter is used, instead of '_id', that specifies the document of interest. The parameters '_index' and '_type' determine the mapping and therefore analyzers to apply to each value field. Closes #7530
This was referenced Dec 8, 2014
Mpdreamz
added a commit
that referenced
this pull request
Dec 12, 2014
Mpdreamz
added a commit
that referenced
this pull request
Dec 12, 2014
…m Vectors: Support for artificial documents #7530'
This was referenced May 6, 2015
clintongormley
changed the title
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
…m Vectors: Support for artificial documents elastic#7530'
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to the Term Vector API to generate term vectors for
artifical documents, that is for documents not present in the index. Following
a similar syntax to the Percolator API, a new 'doc' parameter is used, instead
of '_id', that specifies the document of interest. The parameters '_index' and
'_type' determine the mapping and therefore analyzers to apply to each value
field.