Test: Randomly enable AggressiveOpts in builds #7533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mrsolo can you take a look? |
| @@ -50,7 +50,8 @@ | |||
| 'tests.jvm.argline' => [ | |||
| {:choices => ['-server'], :method => 'get_random_one'}, | |||
| {:choices => ['-XX:+UseConcMarkSweepGC', '-XX:+UseParallelGC', '-XX:+UseSerialGC', '-XX:+UseG1GC'], :method => 'get_random_one'}, | |||
| {:choices => ['-XX:+UseCompressedOops', '-XX:-UseCompressedOops'], :method => 'get_random_one'} | |||
| {:choices => ['-XX:+UseCompressedOops', '-XX:-UseCompressedOops'], :method => 'get_random_one'}, | |||
| {:choices => ['-XX:+AggressiveOpts'], :method => 'get_random_one_or_none'} | |||
There was a problem hiding this comment.
New method is not needed.
Use this instead
{:choices => ['-XX:+AggressiveOpts'], :method => 'get_50_percent'}
|
The change exposes the bug in line 293 s[k] = v.join(' ') #this should be dependent on class of v[0] and perform reduce operation instead... good enough for now. tests.javm.argline will be quoted if AgressiveOpts isn't picked tests.jvm.argline: -server -XX:+UseSerialGC -XX:+UseCompressedOops -XX:+AggressiveOpts tests.jvm.argline: '-server -XX:+UseG1GC -XX:-UseCompressedOops ' changing the line to s[k] = v.compact.join(' ') will address the issue |
|
@mrsolo thanks for the review I pushed a new commit |
|
LGTM.. pushing code change through CI |
s1monw
force-pushed
the
agressive_opts_build
branch
from
2cc3052
to
8938726
Compare
s1monw
force-pushed
the
agressive_opts_build
branch
from
8938726
to
64dce61
Compare
clintongormley
changed the title
clintongormley
changed the title
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to catch JVM bugs earlier I'd love to run builds randomly with
-XX:+AggressiveOpt