Test: use local random instance rather than thread local version #7665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1monw
added
>test
This influences reprocucibility dramatically since it modifies the test random sequence while it should just use the private random instance.
s1monw
force-pushed
the
fix_internal_test_cluster
branch
from
8264802
to
b0cf929
Compare
|
LGTM, thanks @s1monw |
|
great! thanks for fixing so quickly! |
clintongormley
changed the title
clintongormley
added
>enhancement
v1.4.0.Beta
v1.4.0.Beta1
and removed
v1.4.0.Beta1
v1.4.0.Beta
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This influences reprocucibility dramatically since it modifies the
test random sequence while it should just use the private random
instance.