Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: use local random instance rather than thread local version #7665

Merged
merged 1 commit into from Sep 9, 2014

Conversation

Projects
None yet
4 participants
@s1monw
Copy link
Contributor

s1monw commented Sep 9, 2014

This influences reprocucibility dramatically since it modifies the
test random sequence while it should just use the private random
instance.

[TEST] use local random instance rather than thread local version
This influences reprocucibility dramatically since it modifies the
test random sequence while it should just use the private random
instance.

@s1monw s1monw force-pushed the s1monw:fix_internal_test_cluster branch to b0cf929 Sep 9, 2014

@javanna

This comment has been minimized.

Copy link
Member

javanna commented Sep 9, 2014

LGTM, thanks @s1monw

@brwe

This comment has been minimized.

Copy link
Contributor

brwe commented Sep 9, 2014

great! thanks for fixing so quickly!

@s1monw s1monw merged commit b0cf929 into elastic:master Sep 9, 2014

@s1monw s1monw deleted the s1monw:fix_internal_test_cluster branch Sep 9, 2014

@s1monw s1monw removed the review label Sep 9, 2014

@clintongormley clintongormley changed the title [TEST] use local random instance rather than thread local version Test: use local random instance rather than thread local version Sep 11, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.