Fix percent_terms_to_match
#7754
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parameter `percent_terms_to_match` (number of terms that must match in the generated query) was wrongly set to the top level boolean query. This would lead to zero or all results type of situations. This commit ensures that the parameter is indeed applied to the query of generated terms.
|
LGTM Yet - I think we should really support the common syntax for minimum should match and use |
|
That would definitely be nice. However, I'd prefer to do it in another commit. This commit fixes a bug introduced when switching to using the TVs API (https://github.com/elasticsearch/elasticsearch/pull/7014/files#diff-8790389477fb6c598af492a8e673f858R153), which is a 1.4beta release. |
|
yeah lets open a different issue. so LGTM :) |
alexksikes
added a commit
that referenced
this pull request
Sep 25, 2014
The parameter `percent_terms_to_match` (percentage of terms that must match in the generated query) was wrongly set to the top level boolean query. This would lead to zero or all results type of situations. This commit ensures that the parameter is indeed applied to the query of generated terms. Closes #7754
alexksikes
added a commit
that referenced
this pull request
Oct 2, 2014
The parameter `percent_terms_to_match` (percentage of terms that must match in the generated query) was wrongly set to the top level boolean query. This would lead to zero or all results type of situations. This commit ensures that the parameter is indeed applied to the query of generated terms. Closes #7754
clintongormley
changed the title
percent_terms_to_match
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
The parameter `percent_terms_to_match` (percentage of terms that must match in the generated query) was wrongly set to the top level boolean query. This would lead to zero or all results type of situations. This commit ensures that the parameter is indeed applied to the query of generated terms. Closes elastic#7754
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameter
percent_terms_to_match(number of terms that must match in thegenerated query) was wrongly set to the top level boolean query. This would
lead to zero or all results type of situations. This commit ensures that the
parameter is indeed applied to the query of generated terms.