Dynamic changes to max_merge_count are now picked up by index throttling
#8136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
|
LGTM |
clintongormley
changed the title
max_merge_count are now picked up by index throttling
clintongormley
added
:Core/Infra/Settings
clintongormley
changed the title
max_merge_count are now picked up by index throttlingmax_merge_count are now picked up by index throttling
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
…he next merge start/finish Previously such changes were never noticed, and index throttling kept kicking in at the original setting from startup. Closes elastic#8136 Closes elastic#8132
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
…he next merge start/finish Previously such changes were never noticed, and index throttling kept kicking in at the original setting from startup. Closes elastic#8136 Closes elastic#8132
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, index throttling won't notice any dynamic/live changes to max_merge_count.
So, I just fixed the throttle code to ask the MergeSchedulerProvider for its maxMergeCount every time a merge starts/finishes.
This means after a dynamic change, it will be the next merge that starts/finishes until the throttling notices the change. We could also install an UpdateSettingsListener to force throttling to notice the change immediately, but that's more complex and I think this simple solution is sufficient.
Closes #8132