Enable ClusterInfoService by default #8206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakrone
added
>bug
v1.3.5
v1.4.0.Beta1
v1.4.0
v2.0.0-beta1
v1.5.0
review
and removed
v1.4.0.Beta1
labels
|
LGTM good catch |
Since we enabled the disk threshold decider by default, we need to enable the cluster info service so that disk usages and shard sizes can be gathered also. Adds a test that checks that we are gathering information by default.
dakrone
force-pushed
the
fix-cluster-info-service
branch
from
71706c1
to
19514a2
Compare
clintongormley
changed the title
clintongormley
changed the title
lcawl
added
:Distributed/Distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we enabled the disk threshold decider by default, we need to
enable the cluster info service so that disk usages and shard sizes can
be gathered also.
Adds a test that checks that we are gathering information by default.
I also talked to @bleskes about how to test both the
InternalClusterInfoServiceandDiskThresholdDeciderat an integrationlevel, and he suggested mocking the responses at the transport layer. I
will work on that for a subsequent pull request after this one.