Introduce elasticsearch.in.bat (i.e. es.in for Windows)

[costin]

Break-out common functionality between elasticsearch.bat and service.bat
Relates #8237

[kimchy]

LGTM, can't verify it on windows now, maybe someone else can?

[dadoonet]

Wondering if we should also change plugin.bat to have a single place where we can define some settings.

For example, if someone want to set path.plugins in elasticsearch.in.bat, it should be taken into account by the plugin.bat command as well.
Though that about memory settings, it does not make sense to start the plugin manager with 4gb RAM is the user set ES_HEAP to 4g!

[gmarz]

@costin

Just tested this on my machine and found the following issues with service.bat:

(1) If service.bat is ran from outside of the bin directory, then it fails to install:

PS C:\elasticsearch\elasticsearch-1.4.0.Beta1> .\bin\service.bat install
Installing service      :  "elasticsearch-service-x64"
Using JAVA_HOME (64-bit):  "C:\Program Files\Java\jdk1.7.0_71"
'C:\elasticsearch\elasticsearch-1.4.0.Beta1\elasticsearch.in.bat' is not recognized as an internal or external command,
operable program or batch file.
The service 'elasticsearch-service-x64' has been installed.

The cause of this is because %~dp0 resolves to C:\elasticsearch\elasticsearch-1.4.0.Beta1 instead of the script directory as you would expect: C:\elasticsearch\elasticsearch-1.4.0.Beta1\bin. I'm confused as to why this is the case though; it works as expected in elasticsearch.bat.

(2) The service name is installed as Elasticsearch ${project.version} instead of Elasticsearch 1.4.0.Beta.

[gmarz]

@costin The shift command on line 40 is what's throwing off the value of %~dp0. Changing this line to CALL %SCRIPT_DIR%elasticsearch.in.bat fixes the issue. I'm just not sure why this wasn't always a problem?

[costin]

@gmarz Thanks. Fixed it through %ES_HOME%\bin (it's what we use through-out the script).

[gmarz]

LGTM 👍

[s1monw]

I think this should go into 1.4 as well

[costin]

#8243 or some parts of it should go in 1.3 as it provides ES_USE_IPV4 for Windows files. The common elasticsearch.in.bat could be left for 1.4 but the option needs to be added in.

[clintongormley]

@Mpdreamz could you review this one too please?

[Mpdreamz]

LGTM 👍 @gmarz's issues seem to have all been resolved.

Passing parameters such as -Des.cluster.name=x still work as well

elasticsearch plugin service seem to work properly no matter from where they are called.

[costin]

Rebased as is into 1.4, 1.x and master. Added only ES_USE_IPV4 setting to 1.3 to avoid introducing elasticsearch.in.bat (a potentially large change) to the 1.3.x series.