Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support external versioning for deletes arriving before initial update #1351

Closed
jfiedler opened this issue Sep 21, 2011 · 3 comments
Closed

Support external versioning for deletes arriving before initial update #1351

jfiedler opened this issue Sep 21, 2011 · 3 comments
Labels
>enhancement v0.17.8 v0.18.0

Comments

@jfiedler
Copy link
Contributor

The versioning feature works well for protecting the index against stale updates due to message reordering (e.g. in a messaging system). However, there is one case not handled properly yet which is when a delete (with external version number) arrives before the first update of the document (with external version number).

Find more on that in this group thread (that asked to file this as enhancement request): https://groups.google.com/d/topic/elasticsearch/QXn1wK01THE/discussion
@kimchy
Copy link
Member

kimchy commented Sep 21, 2011

Already fixed here #1341 :)

@kimchy kimchy closed this as completed Sep 21, 2011
@jfiedler
Copy link
Contributor Author

I moved to 0.17.7 but my little test case is still red. Not sure #1341 really is the same as this issue. This is my test case: I trigger a delete with external version number 2 and then trigger an update with external version 1 (simulating message reordering). I am expecting the update to fail with a version conflict exception but it does succeed. When debugging I see the delete failing with a version conflict (current -1 but expected 2). The update then succeeds.

@kimchy kimchy reopened this Sep 22, 2011
@kimchy
Copy link
Member

kimchy commented Sep 22, 2011

Yea, you are right, I missed that interaction model, will fix.

@kimchy kimchy closed this as completed in d76d7d4 Sep 22, 2011
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@kimchy
Support external versioning for deletes arriving before initial update,
8a67aa7 
closes elastic#1351.
jev001 pushed a commit to jev001/elasticsearch that referenced this issue Dec 28, 2022
@kimchy
Support external versioning for deletes arriving before initial update,
3d53398 
closes elastic#1351.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>enhancement v0.17.8 v0.18.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kimchy @jfiedler