Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing else? #4390

Closed
twinforces opened this issue Dec 10, 2013 · 2 comments
Closed

Missing else? #4390

twinforces opened this issue Dec 10, 2013 · 2 comments
Assignees
@s1monw
Labels
>bug v0.90.8 v1.0.0.RC1

Comments

@twinforces
Copy link

I think there should be an else here

I think there should be an else here. Otherwise the code inside the if is irrelevant, because the put outside the if will overwrite the results.
@s1monw
Copy link
Contributor

s1monw commented Dec 10, 2013

Makes sense - I will fix

@s1monw s1monw closed this as completed in acf371e Dec 10, 2013
s1monw added a commit that referenced this issue Dec 10, 2013
@s1monw
Do not override thetas if sum is less or equals to 0
a3c93ec 
Closes #4390
@twinforces
Copy link
Author

Thanks Simon! You Rock!

@ghost ghost assigned imotov and s1monw Dec 10, 2013
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@s1monw
Do not override thetas if sum is less or equals to 0
28301d3 
Closes elastic#4390
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s1monw s1monw

Labels
>bug v0.90.8 v1.0.0.RC1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@imotov @twinforces @s1monw