Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] - Expose headers on HttpRequest #4609

Closed
lmenezes opened this issue Jan 3, 2014 · 7 comments
Closed

[Feature Request] - Expose headers on HttpRequest #4609

lmenezes opened this issue Jan 3, 2014 · 7 comments
Assignees
@s1monw
Labels
>enhancement v0.90.10 v1.0.0.RC1

Comments

@lmenezes
Copy link
Contributor

lmenezes commented Jan 3, 2014

There is a method available for retrieving the value of a header, but it's not possible to iterate over all headers.

Is there a reason why this is not exposed? If not, would be nice having that.
@lmenezes
Copy link
Contributor Author

lmenezes commented Jan 3, 2014

btw, it would also be totally fine just exposing the list of header names.

@s1monw
Copy link
Contributor

s1monw commented Jan 3, 2014

do you wanna come up with a PR?

@lmenezes
Copy link
Contributor Author

lmenezes commented Jan 3, 2014

sure. thanks :)

@lmenezes lmenezes mentioned this issue Jan 4, 2014
Closed
@lmenezes
Copy link
Contributor Author

lmenezes commented Jan 6, 2014

@s1monw I just created a wrapper for the headers. When pushing -f We lost part of the comments that were there.
I created the wrapper, deprecated the current getHeader and updated parts of the code that were using the deprecated method. Looks good now?

By the way, how do you usually work with updating a pull request like this? Just rebasing and push -f?

@s1monw
Copy link
Contributor

s1monw commented Jan 6, 2014

I think it looks good. Would you mind adding some javadocs to the new interface? I usually try to just stack up commits until we are good to go and then squash once everybody is happy.

@lmenezes
Copy link
Contributor Author

lmenezes commented Jan 6, 2014

Javadocs done. Let me know if there is anything else.

lmenezes pushed a commit to lmenezes/elasticsearch that referenced this issue Jan 6, 2014
Expose headers list in RestRequest
f59c71a 
closes elastic#4609
@ghost ghost assigned s1monw Jan 8, 2014
@s1monw
Copy link
Contributor

s1monw commented Jan 8, 2014

pushed

@s1monw s1monw closed this as completed Jan 8, 2014
@clintongormley clintongormley mentioned this issue Jan 15, 2014
Closed
brusic pushed a commit to brusic/elasticsearch that referenced this issue Jan 19, 2014
@brusic
Expose headers list in RestRequest
f27213a 
Closes elastic#4609
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@s1monw
Expose headers list in RestRequest
34e2dcf 
Closes elastic#4609
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s1monw s1monw

Labels
>enhancement v0.90.10 v1.0.0.RC1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lmenezes @s1monw