Mark 'lucene-expression' as 'provided' in pom.xml #4859
Labels
:Delivery/Packaging
RPM and deb packaging, tar and zip archives, shell and batch scripts
Team:Delivery
Meta label for Delivery team
v0.90.11
v1.0.0.RC2
v1.1.0
v2.0.0-beta1
Comments
|
I think the main problem is when using elasticsearch as a embedded client jar, and then I agree, we should make sure its optional. I think that we will end up integrating with it though (as a script engine?), so it will be part of our full distribution eventually. I think provided will work then as well. |
|
agreed |
s1monw
added a commit
that referenced
this issue
Jan 23, 2014
We currently pull in the lucene-expression module that is referenced by lucene-suggest. Yet, we don't make use of this dependency at all and it pulls in a bunch of unshaded libs like `antlr` and `asm` which are pretty common in other projects. We should exclude this dependency since we don't use it at all and it causes problems when Elasticsearch is used as a node client. (see #4858) If we mark the dependency as provided it won't be included in the distribution. Closes #4859 Closes #4858
s1monw
added a commit
that referenced
this issue
Jan 23, 2014
We currently pull in the lucene-expression module that is referenced by lucene-suggest. Yet, we don't make use of this dependency at all and it pulls in a bunch of unshaded libs like `antlr` and `asm` which are pretty common in other projects. We should exclude this dependency since we don't use it at all and it causes problems when Elasticsearch is used as a node client. (see #4858) If we mark the dependency as provided it won't be included in the distribution. Closes #4859 Closes #4858
s1monw
added a commit
that referenced
this issue
Jan 23, 2014
We currently pull in the lucene-expression module that is referenced by lucene-suggest. Yet, we don't make use of this dependency at all and it pulls in a bunch of unshaded libs like `antlr` and `asm` which are pretty common in other projects. We should exclude this dependency since we don't use it at all and it causes problems when Elasticsearch is used as a node client. (see #4858) If we mark the dependency as provided it won't be included in the distribution. Closes #4859 Closes #4858
|
Just an idea: Why not make a elasticsearch-client artifact which does only contain dependencies needed for client only nodes? Would that still require all those lucene dependencies? |
clintongormley
added
:Delivery/Packaging
mute
pushed a commit
to mute/elasticsearch
that referenced
this issue
Jul 29, 2015
We currently pull in the lucene-expression module that is referenced by lucene-suggest. Yet, we don't make use of this dependency at all and it pulls in a bunch of unshaded libs like `antlr` and `asm` which are pretty common in other projects. We should exclude this dependency since we don't use it at all and it causes problems when Elasticsearch is used as a node client. (see elastic#4858) If we mark the dependency as provided it won't be included in the distribution. Closes elastic#4859 Closes elastic#4858
mute
pushed a commit
to mute/elasticsearch
that referenced
this issue
Jul 29, 2015
We currently pull in the lucene-expression module that is referenced by lucene-suggest. Yet, we don't make use of this dependency at all and it pulls in a bunch of unshaded libs like `antlr` and `asm` which are pretty common in other projects. We should exclude this dependency since we don't use it at all and it causes problems when Elasticsearch is used as a node client. (see elastic#4858) If we mark the dependency as provided it won't be included in the distribution. Closes elastic#4859 Closes elastic#4858
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We currently pull in the
lucene-expressionmodule that is referenced bylucene-suggest. Yet, we don't make use of this dependency at all and it pulls in a bunch of unshaded libs likeantlrandasmwhich are pretty common in other projects. We should exclude this dependency since we don't use it at all and it causes problems when Elasticsearch is used as a node client. (see #4858 )If we mark the dependency as provided it won't be included in the distribution.
The text was updated successfully, but these errors were encountered: