New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Lucene 4.9 #6623
Upgrade to Lucene 4.9 #6623
Conversation
@@ -35,7 +35,8 @@ | |||
@Inject | |||
public DiskDocValuesFormatProvider(@Assisted String name, @Assisted Settings docValuesFormatSettings) { | |||
super(name); | |||
this.docValuesFormat = new DiskDocValuesFormat(); | |||
// TODO: log a warning if someone chooses this? just remove this together and map it to the 4.9 provider? | |||
this.docValuesFormat = new Lucene49DocValuesFormat(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove it completely? If someone was using this format he had to change the format to the default one and run optimize before upgrading anyway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, but would prefer if we do such things in a followup issue. This upgrade is plenty complicated already.
I left one comment, I think it looks good otherwise |
LGTM |
1 similar comment
LGTM |
No description provided.