Upgrade to Lucene 4.9 #6623
Closed
Upgrade to Lucene 4.9 #6623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -35,7 +35,8 @@ | |||
| @Inject | |||
| public DiskDocValuesFormatProvider(@Assisted String name, @Assisted Settings docValuesFormatSettings) { | |||
| super(name); | |||
| this.docValuesFormat = new DiskDocValuesFormat(); | |||
| // TODO: log a warning if someone chooses this? just remove this together and map it to the 4.9 provider? | |||
| this.docValuesFormat = new Lucene49DocValuesFormat(); | |||
There was a problem hiding this comment.
I think we should remove it completely? If someone was using this format he had to change the format to the default one and run optimize before upgrading anyway?
There was a problem hiding this comment.
I agree, but would prefer if we do such things in a followup issue. This upgrade is plenty complicated already.
|
I left one comment, I think it looks good otherwise |
|
LGTM |
1 similar comment
|
LGTM |
rmuir
added a commit
that referenced
this pull request
Jun 26, 2014
clintongormley
added
:Core/Infra/Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.