StripeDialog: Put the money icon in the right place depending on the locale #1663
Conversation
…locale. In French we would write "5 $" and never "$ 5".
tintou
force-pushed
the
tintou/money-position
branch
from
32b35ab
to
6f3cb5f
Compare
|
I'm conflicted on this because we always put icons which describe the purpose of the entry in the primary position and it really messes up the layout to move it. It's more of a modifier to the entry itself than to number inside of the entry |
|
I feel like here the exception is that the icon is actually a label (using the same weight and font than a normal label) so it really looks weird for me as a french speaker. |
|
It's a different weight and font and spacing also :p
|
There was a problem hiding this comment.
I'm kind of indifferent on the design; if the French person expects it on the right, I'm inclined to listen even if it looks funky to us. But I'm unable to confirm this actually uses the locale setting; I've set my locale to use French formats and rebooted, but the dialog in this branch still has it on the left.
|
@cassidyjames we're not using LC_MONETARY and I really don't know any software that actually use that, we just rely on the language |
In French we would write "5 $" and never "$ 5".