Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppInfoView: replace combobox with dropdown #2117

Merged
merged 9 commits into from
Feb 28, 2024

Conversation

danirabbit
Copy link
Member

Knocks out a couple deprecation warnings by using dropdown and Glib.ListStore

@danirabbit danirabbit requested a review from a team February 15, 2024 21:30
Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as it should however when clicking the dropdown button its background becomes transparent so that it has the banner background color

@danirabbit
Copy link
Member Author

@leolost2605 fixed! Just a reminder, you need to do ninja clean to rebuild CSS

src/Views/AppInfoView.vala Outdated Show resolved Hide resolved
@danirabbit
Copy link
Member Author

@leolost2605 can I get a re-review? :)

Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry kinda forgot about this 😔

LGTM!

@danirabbit danirabbit merged commit c766060 into main Feb 28, 2024
2 of 4 checks passed
@danirabbit danirabbit deleted the danirabbit/origin-dropdown branch February 28, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants