Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Php7 #2339

Merged
merged 4 commits into from Jan 26, 2016
Merged

Php7 #2339

merged 4 commits into from Jan 26, 2016

Conversation

emanuele45
Copy link
Contributor

And finally added support for PHP 7 in tests (and ElkArte as well, of course :P).
The problem were two:

  1. session handling was broken, thanks to @albertlast (and his pull request at SMF) for putting me on the right track,
  2. the eval function has a different behaviour that requires a try/catch breaking the php syntax validation function

@emanuele45 emanuele45 added this to the 1.1 Beta 1 milestone Jan 2, 2016
@emanuele45
Copy link
Contributor Author

It passes the tests so I guess we can bring it in. 😛

emanuele45 added a commit that referenced this pull request Jan 26, 2016
@emanuele45
Merge pull request #2339 from emanuele45/php7
66957d9 
Php7
@emanuele45 emanuele45 merged commit 66957d9 into elkarte:development Jan 26, 2016
@emanuele45 emanuele45 deleted the php7 branch January 26, 2016 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.1 Beta 1
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@emanuele45