-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework of namespaces, directory structure and class loader #3256
Conversation
… autoloader will reside
…and tests, left for later when the code will start running again
…PSR4 instead of... I think PSR0
…plit and namespaced)
…f the new autoloader
…o sources/ElkArte
…oser ClassLoader because otherwise it will conflict with the composer loaded during the setup of the tests
Looking good ! Would the plan be to update our db calls so we can in the core not use any of the temporary migration functions and just leave those for addons? |
Well... I doubt I can update all the calls in this very PR, though I added a backward compatibility "layer" with tracked errors, so that old-style calls can be identified. |
Cool .. yes I meant change them as we go along, not all in this PR, that would be crazy man ! |
…f "old-style" database querying because it was causing session errors, plus a couple of files I forgot to commit previously
…gn them to the rest of the database code
…AbstractQuery class
…ase code organization
…ke of extending a class that is not a singleton and has the constructor public... fugly - oh well, I'll fix it one day... I guess
… available provided by the injection? Good question!
8d01c4a
to
b1b9546
Compare
…ery::db_list_tables to avoid having to rewrite some parts of the code + fix the Dump class that was still poiting to the old methods
b1b9546
to
2ab3bf1
Compare
…s in database(), now they are defined
926c8e5
to
689a491
Compare
I'm almost lost... can't understand what the heck it fails on installing the tests with an
😖 |
202d44f
to
dd2b68c
Compare
…of it. From now on it should not be necessary
d83ea74
to
a0d9e58
Compare
f9537db
to
bc233b5
Compare
YAY! One thing I'm not sure about is the upgrade, but to be honest, at the moment I don't want to know. 😆 |
MERGE !!!!!! |
👯♀️ 👯♂️ 💃 👯♂️ 👯♀️ |
I used the composer classloader (PSR4), on top of that moved all the classes to an ElkArte directory (to which an ElkArte namespace corresponds) inside sources. From there reworked all the namespaces and class names and file names in order to match the convention.
Fixes #3253