Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ant's Theme updates #605

Merged
merged 3 commits into from Jul 3, 2013
Merged

Ant's Theme updates #605

merged 3 commits into from Jul 3, 2013

Conversation

eurich
Copy link
Member

@eurich eurich commented Jul 2, 2013

This is a quick one to get some minor tidying up out of the way, before I rebuild the board index and mesage index into non-tabular markup. I'm just getting similar areas more consistent in markup and css.


css/index.css:
Have bumped the body text size a fraction (from 10pt to 14px). Should be better all round.
Consequently, I'm calling some odd-looking font-sizes in em now.
Trust me on this one. They're only numbers, and it'll work well once it's all sorted.
Most of the rest is just styling tweaks to clean things up a bit. Should be fine.

languages/index.english.php:
Shortened the quote to new topic string so it will fit with the other buttons.

Display.template.php:
Quick reply editor is now more responsive for width (fixes #583).
Quckbuttons have been rearranged to make likes and quote to new topic more workable.
Minor markup clean up. Not much else.

Post.template.php:
Fix for #583, plus minor markup clean up.

Recent.template.php, ProfileInfo.template.php and PersonalMessage.template.php:
Minor markup clean up. More to do.

default/images/_light:
Changed icons to remove tubby moose.

This one gets rid of tables from the board index, message index, unread topics and updated topics (new replies) pages. All lists now.
Media queries still need tweaking for smaller screens. Will do later.
Also tweaked up info centre styling. I'm going consistent everywhere (mostly).

…re I rebuild the board index and mesage index into non-tabular markup. I'm just getting similar areas more consistent in markup and css.

--------------------------------------------------------------------------
css/index.css:
	Have bumped the body text size a fraction (from 10pt to 14px). Should be better all round.
	Consequently, I'm calling some odd-looking font-sizes in em now.
	Trust me on this one. They're only numbers, and it'll work well once it's all sorted.
	Most of the rest is just styling tweaks to clean things up a bit. Should be fine.

languages/index.english.php:
	Shortened the quote to new topic string so it will fit with the other buttons.

Display.template.php:
	Quick reply editor is now more responsive for width (fixes #583).
	Quckbuttons have been rearranged to make likes and quote to new topic more workable.
	Minor markup clean up. Not much else.

Post.template.php:
	Fix for #583, plus minor markup clean up.

Recent.template.php, ProfileInfo.template.php and PersonalMessage.template.php:
	Minor markup clean up. More to do.

default/images/_light:
	Changed icons to remove tubby moose.
Signed-off-by:Antechinus <darthechidna@bigpond.com>
…ad topics and updated topics (new replies) pages.

All lists now. 
Media queries still need tweaking for smaller screens. Will do later.
Also tweaked up info centre styling. I'm going consistent everywhere (mostly).
Signed-off-by:Antechinus <darthechidna@bigpond.com>
@StealthWombat
Copy link
Contributor

BTW, the reason for the odd font-size and line-height declarations is to get things pixel perfect in all browsers at default browser font size. It still works well (to within 1px) even with greatly enlarged text.

Using exact sizing and heights allows IE to still resize text (which it couldn't if things were sized in px), while allowing the use of slightly different font sizes for visual hierarchy.

Trying to round them off will result in things going slightly wonky, which IMO aint good. It's only numbers anyway, and we might as well have slick layout.

@eurich
Copy link
Member Author

eurich commented Jul 3, 2013

I'll commit fixes for the missing closing </li> soon,

…</li>

Signed-off-by:Antechinus <darthechidna@bigpond.com>
@eurich
Copy link
Member Author

eurich commented Jul 3, 2013

@emanuele45 Any objections or can we merge this? The PersonalMesage.template.php is affected, so it might conflict with your PM (personal messages) to PD (personal discussions) migration.

@emanuele45
Copy link
Contributor

Don't worry about what I say I'm doing, it may take months to have a presentable shape! 😉
Go on and merge, in case there is always rebase. 😁

eurich added a commit that referenced this pull request Jul 3, 2013
@eurich eurich merged commit e46e34e into elkarte:master Jul 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants