Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

News #610

Merged
merged 2 commits into from Jul 4, 2013
Merged

News #610

merged 2 commits into from Jul 4, 2013

Conversation

emanuele45
Copy link
Contributor

A couple of quick fixes for the news fader.

…t calls getNews...let's drop it

Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
emanuele45 added a commit that referenced this pull request Jul 4, 2013
@emanuele45 emanuele45 merged commit 647342c into elkarte:master Jul 4, 2013
@emanuele45 emanuele45 deleted the news branch July 4, 2013 17:04
@StealthWombat
Copy link
Contributor

ROFL. Ok, I'll need to tweak the css slightly then. No prob.

@emanuele45
Copy link
Contributor Author

:P

@StealthWombat
Copy link
Contributor

Ha. Tag-agnostic CSS ftw. Doesn't need tweaking. Still works. 😀

One minor thing: we can drop the comments and save an echo.

function template_news_fader()
{
    global $settings, $options, $txt, $context;

    echo '
    <div id="newsfader" class="forum_category">
        <h2 class="category_header">
            <img id="newsupshrink" src="', $settings['images_url'], '/collapse.png" alt="*" title="', $txt['hide'], '" style="display: none;vertical-align: bottom" />
            ', $txt['news'], '
        </h2>
        <ul id="smfFadeScroller"', empty($options['collapse_news_fader']) ? '' : ' style="display: none;"', '>
            <li>
                ', implode('</li><li>', $context['news_lines']), '
            </li>
        </ul> 
    </div>

@StealthWombat
Copy link
Contributor

Hey speaking of the news: on my local there's no admin boxes to put news in. Wossup with that?

ETA: NVM. Got it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants