Update stripe to latest package/api version #1345
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlcx
force-pushed
the
lets-upgrade-stripe
branch
from
9d47aa4
to
510992d
Compare
|
Hang on, why not just instantiate the stripe client each time? Are we very concerned with performance? Less global state feels better... |
|
It's more about connecting the config to the library in one place, rather than performance. You can replace it with a |
|
Yeah that's what I was thinking. In terms of type checking properly and avoiding globals, I'd have thought so! |
wlcx
force-pushed
the
lets-upgrade-stripe
branch
from
510992d
to
6f0afc4
Compare
wlcx
force-pushed
the
lets-upgrade-stripe
branch
from
ef89edb
to
7e52407
Compare
wlcx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not suggesting that we necessarily merge this in time for ticket sales!
Issues:
stripe_clientisNone|Any?