fix: STOMP heartbeat #12920
Open
fix: STOMP heartbeat #12920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HJianBo
requested changes
Apr 24, 2024
| @@ -700,6 +700,16 @@ parse_incoming( | |||
|
|
|||
| parse_incoming(<<>>, Packets, State) -> | |||
| {Packets, State}; | |||
| parse_incoming( | |||
There was a problem hiding this comment.
Since emqx_gateway_conn is generic code for all gateways, we should not handle stomp-related frame here.
It's better to handle it in emqx_stomp_frame.erl module
There was a problem hiding this comment.
In emqx_stomp_frame.erl module, not have the channel info, how can i do?
There was a problem hiding this comment.
IMO, you can return a new frame type, i.e. heartbeat and handle it in the channel module. But I am not sure if the heartbeat message contains only one \n char.🤔
There was a problem hiding this comment.
I have updated it, if it is not perfect, maybe you can improve it.
cisiqo
force-pushed
the
patch-6
branch
2 times, most recently
from
96bb72f
to
51f202c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12911
Fix server not send heartbeat to client and client send heartbeat to server, the server keep alive.
Summary
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.mdfilesChecklist for CI (.github/workflows) changes
changes/dir for user-facing artifacts update