Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STOMP GW does not send heartbeat to client #12911

Closed
shinedd opened this issue Apr 22, 2024 · 9 comments · Fixed by #12920
Closed

STOMP GW does not send heartbeat to client #12911

shinedd opened this issue Apr 22, 2024 · 9 comments · Fixed by #12920
Assignees
Labels

Comments

@shinedd
Copy link

shinedd commented Apr 22, 2024

What happened?

I am using obuspa as a stomp client to test with emqx stomp gw, and i get a error message:
image

What did you expect to happen?

Could emqx stomp gw support sending heartbeat to stomp client

How can we reproduce it (as minimally and precisely as possible)?

No response

Anything else we need to know?

No response

EMQX version

sysdescr : EMQX
version : 5.5.1
datetime : 2024-04-22T19:25:59.961416581+08:00
uptime : 10 days, 9 hours, 35 minutes, 26 seconds

OS version

# On Linux:
$ cat /etc/os-release
# paste output here
$ uname -a
# paste output here

Log files

@shinedd shinedd added the BUG label Apr 22, 2024
@HJianBo HJianBo self-assigned this Apr 23, 2024
@HJianBo
Copy link
Member

HJianBo commented Apr 23, 2024

Hi, @shinedd I'm not sure what's kinds of Heartbeat you mentioned, because the standard stomp v1.2 protocol spec doesn't have heartbeat definition https://stomp.github.io/stomp-specification-1.2.html#Client_Frames

Could you give me some code examples to reproduce that?

@shinedd
Copy link
Author

shinedd commented Apr 23, 2024

I'm new for stomp, i just find this problem during testing with tr369 client:
https://github.com/BroadbandForum/obuspa
And when i change cx > 0 or cy > 5000
image
I will get this error log

@cisiqo cisiqo mentioned this issue Apr 23, 2024
9 tasks
@shinedd
Copy link
Author

shinedd commented Apr 24, 2024

When i set cy to 5000, i found the heartbeat interval is about 15s in captured package
image

@cisiqo
Copy link
Contributor

cisiqo commented Apr 26, 2024

@shinedd yes, my branch had fix the bug, you can use to test.

@shinedd
Copy link
Author

shinedd commented Jun 14, 2024

@cisiqo
this is the heartbeat that i test with Apache ActiveMQ Artemis, cx cy is 3000 2000
image
this is testing with emqx instance builded from todays master branch, cx cy is 3000 2000
image
stomp client still can not receive heartbeat from emqx stably

@cisiqo
Copy link
Contributor

cisiqo commented Jun 14, 2024

Oh, no. Please pay attention to this #12920 (comment)
After the server receives the heartbeat packet from the client, it seems not to reset the counter.

@shinedd
Copy link
Author

shinedd commented Jun 17, 2024

I have tested with this branch https://github.com/cisiqo/emqx/tree/patch-6
The test results are the same

@cisiqo
Copy link
Contributor

cisiqo commented Jun 17, 2024

Try it again, i have fix it.

@shinedd
Copy link
Author

shinedd commented Jun 18, 2024

image
it seems work, tks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants