Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: logger json formatter's config not working #8518

Merged
merged 2 commits into from Jul 22, 2022
Merged

fix: logger json formatter's config not working #8518

merged 2 commits into from Jul 22, 2022

Conversation

zhongwencool
Copy link
Member

@zhongwencool zhongwencool commented Jul 20, 2022 •
edited

The formatter configuration parameter is always ignored when using json schema.
However, restrict char limiter if used for JSON mode, it will get a truncated incomplete json data, which is not practical and not recommended.

codeball-ai-writer[bot]
codeball-ai-writer bot previously approved these changes Jul 20, 2022
View reviewed changes
Copy link

@codeball-ai-writer codeball-ai-writer bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeball: LGTM! 👍 dashboard

@zhongwencool zhongwencool force-pushed the fix-logger-json-format-config-not-working branch from cc7488d to a34c3b0 Compare July 20, 2022 09:27
codeball-ai-writer[bot]
codeball-ai-writer bot previously approved these changes Jul 20, 2022
View reviewed changes
Copy link

@codeball-ai-writer codeball-ai-writer bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeball: LGTM! 👍 dashboard

@coveralls
Copy link
Collaborator

coveralls commented Jul 21, 2022 •
edited

Pull Request Test Coverage Report for Build 2716882738

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 33 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.05%) to 78.837%
Files with Coverage Reduction New Missed Lines %
apps/emqx_management/src/emqx_mgmt_api_trace.erl 1 80.0%
apps/emqx/src/emqx_cm.erl 1 88.99%
apps/emqx/src/emqx_connection.erl 1 84.7%
apps/emqx/src/emqx_stats.erl 1 93.33%
apps/emqx/src/persistent_session/emqx_persistent_session.erl 2 93.01%
apps/emqx_authn/src/emqx_authn.erl 3 77.78%
apps/emqx/src/emqx_channel.erl 3 86.01%
apps/emqx_management/src/emqx_mgmt_cli.erl 5 29.41%
apps/emqx/src/emqx_sys_mon.erl 6 86.46%
apps/emqx/src/emqx_reason_codes.erl 10 91.18%
Totals Coverage Status
Change from base Build 2715969433: 0.05%
Covered Lines: 20835
Relevant Lines: 26428
💛 - Coveralls

@zhongwencool zhongwencool force-pushed the fix-logger-json-format-config-not-working branch from 8fc0e4c to 4d5dfe2 Compare July 22, 2022 01:48
@zhongwencool zhongwencool force-pushed the fix-logger-json-format-config-not-working branch from cb400a7 to f0f26b2 Compare July 22, 2022 06:59
@zhongwencool zhongwencool merged commit 2cdd63a into emqx:master Jul 22, 2022
@zhongwencool zhongwencool deleted the fix-logger-json-format-config-not-working branch July 22, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terry-xiaoyu terry-xiaoyu terry-xiaoyu approved these changes

@codeball-ai-writer codeball-ai-writer[bot] codeball-ai-writer left review comments

Assignees
No one assigned
Labels
codeball:approved Codeball
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhongwencool @coveralls @terry-xiaoyu