Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: emqx_statsd hot update #9363

Merged
merged 3 commits into from Nov 21, 2022

Conversation

zhongwencool
Copy link
Member

@zhongwencool zhongwencool commented Nov 14, 2022

Refactor emqx_statsd server

  • Add statsd.tags config.
  • Replace state record with map.
  • Fix duplicate prefix keys.
  • Improve test coverage > 90%.
  • Use emqx_config_handler callback to hot update config.

PR Checklist

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/ dir
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • In case of non-backward compatible changes, reviewer should check this item as a write-off, and add details in Backward Compatibility section

Backward Compatibility

More information

Co-authored-by: Zaiming (Stone) Shi <zmstone@gmail.com>
@zhongwencool zhongwencool merged commit 966e6dd into emqx:master Nov 21, 2022
@zhongwencool zhongwencool deleted the statsd-update-api branch November 21, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants