Get node binary via @nodejs//:node #1151
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had a colleague using an arm64 mac whose builds were failing because `platform.machine()` was returning amd64 for some reason (my guess is the python toolchain was running under Rosetta). Then emscripten_config looked for the node binary in a nonexistent directory -- nodejs_darwin_amd64 rather than nodejs_darwin_arm64. This switches to a public rules_nodejs API for obtaining the binary, so should always work.
walkingeyerobot
approved these changes
Dec 17, 2022
auto-merge was automatically disabled
December 20, 2022 02:19
Head branch was pushed to by a user without write access
jfirebaugh
force-pushed
the
jfirebaugh/node_bin
branch
from
38164ca
to
ea458fb
Compare
jfirebaugh
force-pushed
the
jfirebaugh/node_bin
branch
from
cc4b7bd
to
ba2e7fa
Compare
|
I had to make two changes to get
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a colleague using an arm64 mac whose builds were failing because
platform.machine()was returning amd64 for some reason (my guess is the python toolchain was running under Rosetta). Then emscripten_config looked for the node binary in a nonexistent directory -- nodejs_darwin_amd64 rather than nodejs_darwin_arm64.This switches to a public rules_nodejs API for obtaining the binary, so should always work.