[bazel] Use hermetic Python #1333
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kon72
force-pushed
the
bazel_hermetic_python
branch
from
fd21ae3
to
757ad79
Compare
walkingeyerobot
approved these changes
Jan 23, 2024
|
This change looks good, but it looks like the test failures are real. The Linux one is complaining because the user is root and the new python is insisting it shouldn't be run as root; this might just be a configuration issue? The Windows one is complaining about actual dependency failures. These need to be addressed before we can merge. I can take a closer look later this week if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the dependency on system Python.
Also fixes an issue where the build fails on Windows with
--incompatible_strict_action_envflag specified: