Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print graphs and filters #79

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Print graphs and filters #79

wants to merge 5 commits into from

Conversation

mdeff
Copy link
Collaborator

@mdeff mdeff commented May 26, 2020

While this info is also shown in plots, those are not seen on text interfaces.

@mdeff mdeff requested a review from nperraud May 26, 2020 02:44
@mdeff mdeff self-assigned this May 26, 2020
Copy link
Collaborator

@nperraud nperraud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see anything to complain about here.

@nperraud
Copy link
Collaborator

nperraud commented May 27, 2020

Let us merge once the tests are passing. Probably a rebase should do.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 88.345% when pulling 2fd6840 on print-graphs-and-filters into cb06eaf on master.

@mdeff
Copy link
Collaborator Author

mdeff commented Dec 16, 2020

Test fails because scikit-image replaced their camera(man) image from version 0.17.0 (used with python 3.6) to 0.18.0 (used with python 3.7-3.9). Refs: scikit-image/scikit-image#3927, scikit-image/scikit-image#4913, scikit-image/scikit-image#4914.

We can either use another image, or wait until we drop python 3.6 (I'd say right after we make a release) to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants