Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update migration warning #360

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Update migration warning #360

merged 1 commit into from
Mar 24, 2023

Conversation

hnformentin
Copy link
Contributor

The current message looks outdate, since reel6 was already phased out.
Probably could have removed it completely, but better to fail more gracefully if the user falls in the exception.

cat /lustre1/prog/komodo/2023.03.01-py38/enable
if [[ $(uname -r) == *el7* ]] ; then
    export KOMODO_ROOT=/lustre1/prog/komodo
    KOMODO_RELEASE_REAL=2023.03.01-py38

    source $KOMODO_ROOT/$KOMODO_RELEASE_REAL-rhel7/enable
    export PS1="(${KOMODO_RELEASE_REAL}) ${_PRE_KOMODO_PS1}"
    export KOMODO_RELEASE=$KOMODO_RELEASE_REAL
else
    echo -e "Attention! Your machine is running on a RHEL6 environment which is in the process of being phased out.
New versions of komodo will from October 2020 only support RHEL7.
Please migrate as soon as possible. If you have any questions or issues - contact us on #ert-users on Slack or Equinor's Yammer!"
fi

komodo/switch.py Outdated
"which is in the process of being phased out.\n"
"New versions of komodo will from October 2020 only support RHEL7.\n"
"Attention! Your machine is running on an environment "
"that is not supported. Rhel6 has been phased out.\n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Suggest using RHEL6 (caps) as it's more readable. Also suggest removing dramatic exclamation point after Yammer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Fixed :-)

Copy link
Member

@kwinkunks kwinkunks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I remember too that Yammer is called Viva Engage now... but if you write that no-one will have a clue what you're talking about :D

So I think this looks good - nice one

@hnformentin hnformentin merged commit dc58224 into main Mar 24, 2023
@hnformentin hnformentin deleted the migration_warning branch March 24, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants