Tplink archer c20 support #1
Conversation
There was a problem hiding this comment.
Hi,
Thanks for contributing to this very early version of the external TPLink support library.
I put a bit of context about it in your HA PR home-assistant/core#11827
I was not planning to integrate it to HA in this early version but I guess I will still propose a PR and see if HA maintainers want to integrate it as is or prefer to wait it looks more like a library.
Regarding your contribution, I just have a minor comment. Also please keep in mind code here has the same criticality as in HA, meaning that you need to test thoroughly that it won't impact existing TPLink component users if modem is not found.
Eric
| @@ -211,6 +213,53 @@ def _update_info(self): | |||
| return False | |||
|
|
|||
|
|
|||
| class TplinkArcherC20DeviceScanner(Tplink2DeviceScanner): | |||
There was a problem hiding this comment.
Any reason you are inheriting from Tplink2DeviceScanner and not TplinkDeviceScanner like the others? Is it to have their version of get_device_name()? As your scanner is completely different from Tplink2, I think it would be cleaner to inherit from base one.
Add support for TP-Link Archer C20.
See HomeAssistant PR: home-assistant/core#11827