Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

travis: Add Stack and GHC 8.8 #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

travis: Add Stack and GHC 8.8 #21

wants to merge 1 commit into from

Conversation

liyishuai
Copy link

No description provided.

erikd
erikd requested changes Nov 5, 2020
View reviewed changes
Copy link
Owner

@erikd erikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind stack being added to CI, but I do not want to see cabal removed.

@liyishuai
Copy link
Author

Cabal is not removed. The default build script for language: haskell is:

cabal configure --enable-tests && cabal build && cabal test

and I've put the existing cabal haddock and cabal sdist in after_script.

erikd
erikd reviewed Nov 5, 2020
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
@liyishuai
Copy link
Author

CI has passed, including both Cabal and Stack tests. Ready to merge.

@erikd
Copy link
Owner

erikd commented Nov 10, 2020

What has happened to the Travis CI notification?

@liyishuai
Copy link
Author

The current CI seems to run on travis-ci.org. Consider migrating to travis-ci.com which has better integration with GitHub?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikd erikd erikd requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@liyishuai @erikd