lease: remove unnecessary O(log N) heap operation when nothing is expiry #9519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to have "lease" in field name. Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Since heap is already sorted, we can just check first element to see if anything is expiry, rather than popping and pushing it back. If nothing is expiry, pop operation is unnecessary. Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #9519 +/- ##
=========================================
Coverage ? 72.52%
=========================================
Files ? 367
Lines ? 31240
Branches ? 0
=========================================
Hits ? 22656
Misses ? 6955
Partials ? 1629
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since heap is already sorted, we can just check first element
to see if anything is expiry, rather than popping and pushing
it back. If nothing is expiry, pop operation O(log N) is unnecessary.
/cc @xiang90 @mgates @jcalvert
ref. #9418.