New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
params: implement ECIP-1078/1079 feature activation #128
Conversation
> - https://github.com/ethereumclassic/ECIPs/pull/263/files?short_path=d39459a#diff-d39459a451d1f1cf1bb1d6b1fddcb4f0 > - https://github.com/ethereumclassic/ECIPs/pull/261/files#diff-f331ca50d292642838a6be87214ac1e7 Implements 'Phoenix' aka 'Aztlan Fix' fork specification which is described as a 'simultaneous' fork adjacent to the fork specified in ECIP-1061 and ECIP-1072. The intention is to sidestep potential vulnerabilities related to gas costs. Signed-off-by: meows <b5c6@protonmail.com>
Signed-off-by: meows <b5c6@protonmail.com>
f8d4e61
to
3bbcf56
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to explicitly disable EIP 2200. On Mordor it already triggered and on Kotti it will soon. For mainnet, we will decide next week.
proposed block numbers for phoenix/ecip-1078
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- needs to disable eip-2200 on mordor and kotti
- needs to update block numbers for phoenix/ecip-1078
@soc1c Thanks for review. I need to merge some stuff first, but then will address these things soon! |
Signed-off-by: meows <b5c6@protonmail.com>
Implements method for data types implementing ChainConfigurator/ CatHerder interface. Currently Parity, multigethv0, and go-ethereum implementations are bare, and will error if attempted to use. These data types, afaik, do not currently support this configuration. Signed-off-by: meows <b5c6@protonmail.com>
- Disable EIP2200 on mordor and kotti - Updates block activation numbers respectively Signed-off-by: meows <b5c6@protonmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic looks good to me. left two comments for cosmetic improvements.
- Add nil-valued eip1884 field - Add EIP2200 enable/+disable for Classic mainnet reflecting ECIP1061/1078 - Adds nicknames for 3 latest ETC forks Signed-off-by: meows <b5c6@protonmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better late than never - LGTM
Implements 'Phoenix' aka 'Aztlan Fix' fork specification
which is described as a 'simultaneous' fork adjacent
to the fork specified in ECIP-1061 and ECIP-1072.
The intention is to sidestep potential vulnerabilities
related to gas costs.
Signed-off-by: meows b5c6@protonmail.com