New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Show All Option to Pagination Component #1280
Conversation
b8fe36d
to
84c85a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Running into this trying to create a bunch of datetimes/tickets for testing (does not happen in Cafe): #1282 Trying to custom sort a large list crashes the page (video) (does not happen in Cafe): https://www.screencast.com/t/y4kp5blFR5lk |
@garthkoyle FYI, there is a regression in Barista repo - #1281 - I've added a brief summary to the PR of the affected areas. Maybe something else is affected too. |
Edit: please wait for PRs https://github.com/eventespresso/cafe/pull/978 and https://github.com/eventespresso/e2e-tests/pull/38 to be merged to resolve failing E2E tests |
4519451
to
905859a
Compare
905859a
to
9d879bd
Compare
@garthkoyle && @alexkuc && @kingrio13 this branch has been rebased and is no longer dependent on branch |
9d879bd
to
7dd0553
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
7dd0553
to
da03706
Compare
@tn3rb is it safe to rebase this branch or do you have any unpushed commits or changed files locally? |
Git commit sha |
da03706
to
b3ef50d
Compare
Command |
All good on my end. using Barista for Event Espresso I dont see it available in Cafe Repo DEV. |
nope, thank you sir |
this PR:
examples