Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Show All Option to Pagination Component #1280

Merged
merged 2 commits into from May 6, 2024

Conversation

tn3rb
Copy link
Member

@tn3rb tn3rb commented Dec 15, 2023

this PR:

examples

Screenshot from 2023-12-15 11-17-26

Screenshot from 2023-12-15 11-17-55

Screenshot from 2023-12-15 11-18-05

@tn3rb tn3rb self-assigned this Dec 15, 2023
@github-actions github-actions bot added C: UI/UX 🚽 category D: Packages 📦 domain: Barista Packages labels Dec 15, 2023
@tn3rb tn3rb added T: new feature ✨ type: NEW - new features P3: med priority 😐 priority: medium labels Dec 15, 2023
@tn3rb tn3rb requested a review from alexkuc December 15, 2023 19:21
@tn3rb tn3rb changed the title Add "show all" Option to Pagination Component Add Show All Option to Pagination Component Dec 15, 2023
@tn3rb tn3rb force-pushed the NEW/pagination-show-all-option branch from b8fe36d to 84c85a1 Compare December 15, 2023 19:38
alexkuc
alexkuc previously approved these changes Dec 15, 2023
Copy link
Contributor

@alexkuc alexkuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@garthkoyle
Copy link

garthkoyle commented Dec 20, 2023

Running into this trying to create a bunch of datetimes/tickets for testing (does not happen in Cafe): #1282

Trying to custom sort a large list crashes the page (video) (does not happen in Cafe): https://www.screencast.com/t/y4kp5blFR5lk

I see these options:
image
I can see the last ticket:
image

@alexkuc
Copy link
Contributor

alexkuc commented Dec 22, 2023

@garthkoyle FYI, there is a regression in Barista repo - #1281 - I've added a brief summary to the PR of the affected areas. Maybe something else is affected too.

@alexkuc
Copy link
Contributor

alexkuc commented Dec 23, 2023

Imho, this PR should not be merged until #1281 is fixed because currently we have broken changes in master branch

Edit: please wait for PRs https://github.com/eventespresso/cafe/pull/978 and https://github.com/eventespresso/e2e-tests/pull/38 to be merged to resolve failing E2E tests

@kingrio13
Copy link

Filter works perfectly on datetime and ticket
image

image
"show all" option to the per page options in the Pagination component
"96 per page" option
current times displayed as well as the total number of items

@tn3rb tn3rb force-pushed the NEW/pagination-show-all-option branch 2 times, most recently from 4519451 to 905859a Compare January 3, 2024 21:06
@tn3rb
Copy link
Member Author

tn3rb commented Apr 22, 2024

@garthkoyle && @alexkuc && @kingrio13

this branch has been rebased and is no longer dependent on branch NEW/CORE/datetime-status in the Cafe repo and can be tested independently using Cafe DEV branch

Copy link
Contributor

@alexkuc alexkuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@alexkuc
Copy link
Contributor

alexkuc commented May 2, 2024

@tn3rb is it safe to rebase this branch or do you have any unpushed commits or changed files locally?

@alexkuc
Copy link
Contributor

alexkuc commented May 2, 2024

Git commit sha da03706 before rebase

@alexkuc alexkuc force-pushed the NEW/pagination-show-all-option branch from da03706 to b3ef50d Compare May 2, 2024 16:40
@alexkuc
Copy link
Contributor

alexkuc commented May 2, 2024

Command git push --force-with-lease was successful

@alexkuc
Copy link
Contributor

alexkuc commented May 2, 2024

@kingrio13
Copy link

kingrio13 commented May 6, 2024

All good on my end. using Barista for Event Espresso

image
image
image

I dont see it available in Cafe Repo DEV.
i only have 48 there, instead of 96
image
did i missed anything bud @tn3rb

@tn3rb
Copy link
Member Author

tn3rb commented May 6, 2024

@kingrio13

nope, thank you sir

@tn3rb tn3rb merged commit 90c6731 into master May 6, 2024
9 checks passed
@tn3rb tn3rb deleted the NEW/pagination-show-all-option branch May 6, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: UI/UX 🚽 category D: Packages 📦 domain: Barista Packages P3: med priority 😐 priority: medium S11: completed 🚀 status T: new feature ✨ type: NEW - new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EDTR Feature Request: Add "All" to Pagination
7 participants