Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*BLOCKED* Regression from PR 1277 *BLOCKED* #1281

Open
9 of 11 tasks
alexkuc opened this issue Dec 18, 2023 · 16 comments
Open
9 of 11 tasks

*BLOCKED* Regression from PR 1277 *BLOCKED* #1281

alexkuc opened this issue Dec 18, 2023 · 16 comments
Assignees
Labels
C: data systems 🗑 category D: EDTR ✏️ domain: EE Event Editor D: Packages 📦 domain: Barista Packages P2: HIGH priority 😮 priority: high S1: new 👶🏻 status T: bug 🐛 type: FIX - any bug fixes

Comments

@alexkuc
Copy link
Contributor

alexkuc commented Dec 18, 2023

⚠️ until Cafe PR is merged, as a workaround, you can run e2e tests on demand against specific branches #1286 ⚠️


After fixing catastrophic bug in E2E tests for Barista repo (eventespresso/actions#57) it was revealed that PR #1277 has introduced regression. The scope of this issue and subsequent PR is to resolve bugs and restore E2E tests to a passable state.


TODOs

@alexkuc alexkuc added T: bug 🐛 type: FIX - any bug fixes C: data systems 🗑 category D: EDTR ✏️ domain: EE Event Editor D: Packages 📦 domain: Barista Packages P2: HIGH priority 😮 priority: high S1: new 👶🏻 status labels Dec 18, 2023
@alexkuc alexkuc self-assigned this Dec 18, 2023
@alexkuc
Copy link
Contributor Author

alexkuc commented Dec 23, 2023

It looks like the actual datetime is missing the required fields as there is an error saying missing properties (for the fields introduced by PR #1277)

@alexkuc
Copy link
Contributor Author

alexkuc commented Dec 23, 2023

Gonna run quick check against Apollo client to confirm the data is actually coming from Cafe with the correct fields

@alexkuc
Copy link
Contributor Author

alexkuc commented Dec 23, 2023

Coping comment from actions repository

🚧 Regression detected in Barista repository❗

Currently working on pinpointing which PR has caused the regression…

E2E Outcome PR Git Commit
#1277 97408d93
#1275 88527b6a

Edit: make sure to run yarn build before starting E2E tests after checking out aforementioned PRs

@alexkuc
Copy link
Contributor Author

alexkuc commented Dec 23, 2023

Will proceed to first investigate the data coming from the server then will check GraphQL queries in the frontend code.

@alexkuc
Copy link
Contributor Author

alexkuc commented Dec 23, 2023

As I had some issues with Apollo Client DevTools, I added up inspecting variable eventEspressoData which revealed that fields isPostponed and isCancelled are in fact missing. Field status is present so all good there.

@alexkuc
Copy link
Contributor Author

alexkuc commented Dec 23, 2023

Maybe fix is required from Cafe's end since variable eventEspressoData is supplied by Cafe repository

@alexkuc
Copy link
Contributor Author

alexkuc commented Dec 23, 2023

Closer inspection of Cafe repository reveals that fields isPostponed and isCancelled exist only for entity Event but not for entity Datetimes

@alexkuc
Copy link
Contributor Author

alexkuc commented Dec 23, 2023

Adding those fields to GraphQL fixed the fatal issue with frontend code but now datetimes and tickets are missing i.e. gone no results found even without filters. Investigating...

@alexkuc
Copy link
Contributor Author

alexkuc commented Dec 23, 2023

As per PR's #1277 initial comment, branch NEW/CORE/datetime-status is required from the Cafe repository.

@alexkuc
Copy link
Contributor Author

alexkuc commented Dec 23, 2023

Currently checking if merging https://github.com/eventespresso/cafe/pull/978 will enough to resolve bugs for E2E in Barista repository

@alexkuc
Copy link
Contributor Author

alexkuc commented Dec 23, 2023

Test fails because tooltip was changed from open event datetime main menu to event datetime main menu. Investigating.

@alexkuc
Copy link
Contributor Author

alexkuc commented Dec 23, 2023

Everything is good with the label and the tooltip. The issue comes from #1277 as the newly created datetime has now status TBD or To Be Determined.

@alexkuc
Copy link
Contributor Author

alexkuc commented Dec 23, 2023

Fix looks simple - need to set datetime status to Calendar controlled.

Edit: instead, removed filter

@alexkuc
Copy link
Contributor Author

alexkuc commented Dec 23, 2023

@alexkuc
Copy link
Contributor Author

alexkuc commented Apr 4, 2024

After discussion with @tn3rb on Slack, I'll change the default branch for Cafe from DEV to NEW/CORE/datetime-status. After the affecting Cafe PR is merged, the branch can be changed back to DEV.

@alexkuc alexkuc changed the title Regression from PR 1277 *BLOCKED* Regression from PR 1277 *BLOCKED* Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: data systems 🗑 category D: EDTR ✏️ domain: EE Event Editor D: Packages 📦 domain: Barista Packages P2: HIGH priority 😮 priority: high S1: new 👶🏻 status T: bug 🐛 type: FIX - any bug fixes
Projects
None yet
Development

No branches or pull requests

1 participant