New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*BLOCKED* Regression from PR 1277 *BLOCKED* #1281
Comments
It looks like the actual datetime is missing the required fields as there is an error saying missing properties (for the fields introduced by PR #1277) |
In regards to actual data, these fields do exist: Not sure about field |
Gonna run quick check against Apollo client to confirm the data is actually coming from Cafe with the correct fields |
Coping comment from actions repository🚧 Regression detected in Barista repository❗ Currently working on pinpointing which PR has caused the regression…
Edit: make sure to run |
Will proceed to first investigate the data coming from the server then will check GraphQL queries in the frontend code. |
As I had some issues with Apollo Client DevTools, I added up inspecting variable |
Maybe fix is required from Cafe's end since variable |
Adding those fields to GraphQL fixed the fatal issue with frontend code but now datetimes and tickets are missing i.e. gone |
As per PR's #1277 initial comment, branch |
Currently checking if merging https://github.com/eventespresso/cafe/pull/978 will enough to resolve bugs for E2E in Barista repository |
Test fails because tooltip was changed from |
Everything is good with the label and the tooltip. The issue comes from #1277 as the newly created datetime has now status |
Edit: instead, removed filter |
This issue will be fixed by 2 PRs: |
After discussion with @tn3rb on Slack, I'll change the default branch for Cafe from |
After fixing catastrophic bug in E2E tests for Barista repo (eventespresso/actions#57) it was revealed that PR #1277 has introduced regression. The scope of this issue and subsequent PR is to resolve bugs and restore E2E tests to a passable state.
TODOs
error creating datetime
The text was updated successfully, but these errors were encountered: