Fix Message Active Toggle #4009
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works for me. |
| id="ee-on-off-toggle-<?php echo esc_attr($context); ?>" | ||
| type="checkbox" | ||
| value="<?php echo esc_attr($on_off_action); ?>" | ||
| /> |
There was a problem hiding this comment.
I would suggest moving type="checkbox" in front of the input tag in order to have more clear code.
majidabbasi96
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #4008 for initial bug report
The form structure on that particular messages admin page does not follow the same pattern used on every other EE admin page. No idea why a "previous dev" did that but I was unaware when tweaking some of the layout recently. This accidently moved one form inside of the other, which obviously broke things.
This PR: