Fix PHP8 compatibility issues #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. |
tn3rb
requested changes
Mar 25, 2024
| @@ -72,6 +73,7 @@ function Espresso_PayPal($DataArray) | |||
| $this -> NVPCredentials .= $this -> APISubject != '' ? 'SUBJECT=' . $this -> APISubject : ''; | |||
| $this -> NVPCredentials .= $this -> APIMode == 'Signature' ? '&SIGNATURE=' . $this -> APISignature : ''; | |||
|
|
|||
| var_dump($this->NVPCredentials); | |||
There was a problem hiding this comment.
OOPS!
going to go out on a limb here and say it's maybe not a good thing to dump credentials like this 🤔
gateways/stripe/do_transaction.php
Outdated
Comment on lines
41
to
45
| if(method_exists($intent, 'toArray')) { | ||
| $intent_array = $intent->toArray(true); | ||
| } else { | ||
| $intent_array = $intent->__toArray(true); | ||
| } |
There was a problem hiding this comment.
not critical, but it's preferable to use ternaries:
$intent_array = method_exists($intent, 'toArray')
? $intent->toArray(true)
: $intent->__toArray(true);
Comment on lines
20
to
21
| //var_dump($_POST); | ||
| //var_dump($_REQUEST); |
| $multi_reg = FALSE; | ||
| $event_id = isset($_POST['event_id']) ? absint( $_POST['event_id'] ) : isset($_REQUEST['event_id']) ? absint( $_REQUEST['event_id'] ) : ''; | ||
| $registration_id = isset( $_POST['registration_id'] ) ? sanitize_text_field( $_POST['registration_id'] ) : isset( $_REQUEST['registration_id'] ) ? sanitize_text_field( $_REQUEST['registration_id'] ) : FALSE; | ||
| $event_id = isset($_REQUEST['event_id']) ? absint( $_REQUEST['event_id'] ) : ''; |
Comment on lines
+43
to
+44
| 'start_date' => !empty($_POST['recurrence_start_date']) ? sanitize_text_field($_POST['recurrence_start_date']) : '0000-00-00', | ||
| 'event_end_date' => !empty($_POST['recurrence_event_end_date']) ? sanitize_text_field($_POST['recurrence_event_end_date']) : '0000-00-00', |
| @@ -399,7 +399,7 @@ private function _requestRaw($method, $url, $params, $headers) | |||
| $hasFile | |||
| ); | |||
|
|
|||
| if (array_key_exists('request-id', $rheaders)) { | |||
| if (isset($rheaders['request-id'])) { | |||
…{property} is deprecated notices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just prevents fatal's from PHP8
Swaps out instances of each() for foreach()
Adjusts the parameter order passed to implode()
Updates FPDF to the latest version so its works with PHP8.
Fixes a couple of notices.
Patches the Stripe SDK with a couple of fixes.
Uses the 'new' style constructor within PayPal Pro