Add AMD module support for browser version #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If using a client-side js module loader like RequireJS this will allow the markdjown-js library to be used with it rather than being shimmed.
|
Hey @npbee and @evilstreak, some time has passed since then - I can see this being not merged in. At the same time the CI build seems to have failed independently of this very change AFAIU. Probably worth revisiting probability of merging this one in, wdyt? |
|
Yikes, yes it's been a while. I think we can safely close this PR without merging. There looks to be an existing AMD solution here already which I think I just missed at the time. I apologize for the noise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I'm using this library on the client-side only with RequireJS. I've added support to be able to load it as an anonymous AMD module.